[
https://issues.apache.org/jira/browse/BOOKKEEPER-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353522#comment-15353522
]
ASF GitHub Bot commented on BOOKKEEPER-937:
-------------------------------------------
GitHub user dlg99 opened a pull request:
https://github.com/apache/bookkeeper/pull/51
BOOKKEEPER-937 Upgrade protobuf to 2.6
protobuf/protoc 2.4 cannot be installed with brew on mac and building it on
mac always result is build errors hence leaves an option of switching to linux
to run protoc.
I upgraded to 2.6 instead. It is compatible with 2.4 on the wire and shaded
so should not create any problems. All tests passed.
Please ignore changes in java files in attached patch during review; these
are auto-generated.
protobuf 2.4 in compat* dependencies is shaded now to not conflict with 2.6.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlg99/bookkeeper task/BOOKKEEPER-937
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 7a104ca29aa7153cb6cc6f4f6ccc04d83a48aaa7
Author: Andrey Yegorov <[email protected]>
Date: 2016-06-28T18:46:14Z
BOOKKEEPER-937 Upgrade protobuf to 2.6
----
> Upgrade protobuf to 2.6
> -----------------------
>
> Key: BOOKKEEPER-937
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-937
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.5.0
> Reporter: Andrey Yegorov
> Priority: Minor
> Labels: protobuf
>
> I had to update protobuf definition for some internal experiments and found
> that working with protobuf 2.4 is rather inconvenient. It cannot be installed
> with brew on mac and building it on mac always result is build errors hence
> leaves an option of switching to linux to run protoc.
> I decided to upgrade to 2.6 instead. It is compatible with 2.4 on wire and
> shaded so should not create any problems. All tests passed.
> Please ignore changes in java files in attached patch during review; these
> are auto-generated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
