Thank you Flavio, there is no hurry, I can merge it locally and work on a temporary version, no problem
-- Enrico 2016-09-23 10:00 GMT+02:00 Flavio Junqueira <[email protected]>: > Enrico, > > The PR for BK-612 has been reviewed, right? We need to wait for Sijie to show > up because he has been the main committer reviewing it, I'd rather not merge > without his +1. Perhaps he is busy or away, so let's wait. > > -Flavio > >> On 23 Sep 2016, at 08:06, Enrico Olivelli <[email protected]> wrote: >> >> (I'm re-sending this email from another account, as I think the prev >> message went to spam folder) >> >> Hi BookKeepers, >> >> I would like to ping on BOOKKEEPER-612, which has a pending PR. >> >> It is actually blocking the work on >> https://issues.apache.org/jira/browse/BOOKKEEPER-912 Allow >> EnsemblePlacementPolicy to choose bookies using ledger custom data >> (multitenancy support) as this is changes the signature of methods on >> EnsemblePlacementPolicy. >> >> Does anyone have time to review so that it can be committed ? >> >> For me BOOKKEEEPER-912 is a very important feature and I would like to >> work on it for 4.5.0 >> >> This is the issue >> https://issues.apache.org/jira/browse/BOOKKEEPER-612 >> >> This is the PR from Robin >> https://github.com/apache/bookkeeper/pull/56 >> >> >> Thank you very much >> >> Enrico >
