[
https://issues.apache.org/jira/browse/BOOKKEEPER-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591945#comment-15591945
]
ASF GitHub Bot commented on BOOKKEEPER-959:
-------------------------------------------
GitHub user eolivelli opened a pull request:
https://github.com/apache/bookkeeper/pull/67
BOOKKEEPER-959 ClientAuthProvider and BookieAuthProvider Public API used
Protobuf Shaded classes
This fix removes the explicit usage of protobuf from ClientAuthProvider and
BookieAuthProvider API, since protobuf library is shaded and relocated on the
distributed public version of BookKeeper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/bookkeeper BOOKKEEPER-959
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit ef2ca0e23c03dff48d14d7c86c192a57644ad489
Author: eolivelli <[email protected]>
Date: 2016-10-20T14:18:34Z
BOOKKEEPER-959 ClientAuthProvider and BookieAuthProvider Public API used
Protobuf Shaded classes
----
> ClientAuthProvider and BookieAuthProvider Public API used Protobuf Shaded
> classes
> ---------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-959
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-959
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client, bookkeeper-server
> Affects Versions: 4.4.0
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Blocker
> Fix For: 4.5.0
>
>
> With 4.4.0 we introduced the ability to implement custom authentication
> plugins.
> The new interfaces ClientAuthProvider and BookieAuthProvider depend on
> ExtensionRegistry, which is a shaded dependency.
> As a consequence it is not possibile to implement any custom auth provider in
> code outside the project, because shaded/relocated dependencies cannot be
> used.
> We need to break the actual interface and introduce a new way to implement
> such plugins in a portable way
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
