[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658829#comment-15658829
 ] 

ASF GitHub Bot commented on BOOKKEEPER-959:
-------------------------------------------

Github user merlimat commented on the issue:

    https://github.com/apache/bookkeeper/pull/67
  
    Sounds good. 
    
    > is the change on protobuf OK for you, as we know you are the only user of 
such message ?
    
    Yes
    
    > is there any other way to deal with compatibility for you ?
    
    If the bookies with auth turned off will accept a client with auth turned 
on... then we can manage the transition (eg: turn temporarily off the auth and 
deploy the new code). But the same requirement is needed to enable auth on an 
existing cluster.



> ClientAuthProvider and BookieAuthProvider Public API used Protobuf Shaded 
> classes
> ---------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-959
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-959
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client, bookkeeper-server
>    Affects Versions: 4.4.0
>            Reporter: Enrico Olivelli
>            Assignee: Enrico Olivelli
>            Priority: Blocker
>             Fix For: 4.5.0
>
>
> With 4.4.0 we introduced the ability to implement custom authentication 
> plugins.
> The new interfaces ClientAuthProvider and BookieAuthProvider depend on 
> ExtensionRegistry, which is a shaded dependency.
> As a consequence it is not possibile to implement any custom auth provider in 
> code outside the project, because shaded/relocated dependencies cannot be 
> used.
> We need to break the actual interface and introduce a new way to implement 
> such plugins in a portable way



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to