Hi Sijie,
See my responses below:
On Tue, Dec 13, 2016 at 7:12 PM, Sijie Guo <[email protected]> wrote:
> Hi Rithin,
>
> The proposal looks good to me. I have a few comments:
>
> - How will the BookieInfo structure look like?
>
I've updated the wiki with this info now. It looks like this:
> - I like the idea of a general GET_BOOKIE_INFO request. Do you have any
> proposed wire protocol changes?
>
message GetBookieInfoRequest {
enum Flags {
TOTAL_DISK_CAPACITY = 0x01;
FREE_DISK_SPACE = 0x02;
}
// bitwise OR of Flags
optional int64 requested = 1;
}
message GetBookieInfoResponse {
required StatusCode status = 1;
optional int64 totalDiskCapacity = 2;
optional int64 freeDiskSpace = 3;
}
> - I assume that you might need the clients to configure a function to
> compute the weight for a bookie, right? So we can also compute the weight
> based on network bandwidth?
>
I've implemented a separate class called 'WeightedRandomSelection', which
is given a long value, uses it as the basis to do weight based selection.
Please see the details in the pull request I created just now:
https://github.com/apache/bookkeeper/pull/93
> - How does bookie collect the resource information?
>
It is just going through all the ledger directories and is retrieving the
free disk space info and total disk space info. Those are the only two it
is collecting right now and it is collected on demand.
>
> - Sijie
>
> On Mon, Dec 12, 2016 at 11:09 AM, Rithin Shetty <[email protected]> wrote:
>
> > Hi Sijie,
> >
> > I've updated the proposal page now:
> > https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> > BP-2+-+Resource+aware+data+placement.
> > Sorry about the delay.
> >
> > Thanks,
> > --Rithin
> >
> > On Sat, Dec 10, 2016 at 1:45 AM, Sijie Guo <[email protected]> wrote:
> >
> > > As a reminder, we will be discussing the resource aware placement at
> the
> > > meeting next week.
> > >
> > > Rithin, do you mind updating the proposal by next Tue? so we have time
> to
> > > check before the meeting.
> > >
> > > - Sijie
> > >
> > > On Tue, Nov 1, 2016 at 2:29 AM, Sijie Guo <[email protected]> wrote:
> > >
> > > > https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-2+
> > > > -+Resource+aware+data+placement
> > > >
> > > > I created a wiki page for place holder. Anyone that is interested in
> > this
> > > > topic can help fill a basic proposal and drive the discussion?
> > > >
> > > > *Problem*
> > > >
> > > > There are bunch of tickets around talking about placement policy :
> > > > - handle different types of storage (tier storage)
> > > > - handle storage node having different type of resources (resource
> > aware)
> > > > - better to canary/bucket-testing new version (manageability)
> > > >
> > > > It would be good to consolidate these thoughts to provide a common
> > > > framework/solution to meet those basic requirements.
> > > >
> > > > *Proposal*
> > > >
> > > > [TBD]
> > > >
> > > > - Sijie
> > > >
> > > >
> > >
> >
>
