caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r127387138
########## File path: docker/4.4.0-alpine/Dockerfile ########## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpine +MAINTAINER Francesco Caliumi <francesco.cali...@gmail.com> + +# Install required packages +RUN apk add --no-cache \ + bash \ + su-exec + +ENV ZK_SERVERS= \ Review comment: I think this script doesn't handle the commented out option lines, like the majority of options in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/conf/bk_server.conf . It's a good idea anyway, and I'm fine to execute this script before the current substitutions done in run.sh. Maybe in a second step with a version that handles even commented out options? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
