caiok commented on a change in pull request #197: BOOKKEEPER-974: Add an official bookkeeper docker image URL: https://github.com/apache/bookkeeper/pull/197#discussion_r128217985
########## File path: docker/4.4.0-alpine/Dockerfile ########## @@ -0,0 +1,59 @@ +FROM java:openjdk-8-jre-alpine +MAINTAINER Francesco Caliumi <francesco.cali...@gmail.com> + +# Install required packages +RUN apk add --no-cache \ + bash \ + su-exec + +ENV ZK_SERVERS= \ + BK_USER=bookkeeper \ + BK_PORT= \ + BK_BUILD_PORT=3181 \ + BOOKIE_OPTS="" \ + BK_JOURNAL_DIR=/data/journal \ Review comment: No, env vars refer to internal container directories and I don't think it's very useful changing them. Current build already creates three different dirs, so the end user just have to mount the desired host dirs to these dirs. Take a look at makefile example (target run-bk) for seeing this in action. It's just like the common mounting mechanism in unix, the target system will not notice the difference. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
