sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support
for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124879315
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/AuthHandler.java
##########
@@ -167,14 +168,9 @@ public void operationComplete(int rc, AuthToken newam) {
channel.close();
return;
}
- AuthMessage message =
- AuthMessage
- .newBuilder()
- .setAuthPluginName(req.authMessage.getAuthPluginName())
- .setPayload(ByteString.copyFrom(newam.getData()))
- .build();
- channel.writeAndFlush(new
BookieProtocol.AuthResponse(req.getProtocolVersion(),
- message));
+ AuthMessage message =
AuthMessage.newBuilder().setAuthPluginName(req.authMessage.getAuthPluginName())
Review comment:
the changes are unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
