sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support
for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124881543
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
##########
@@ -272,7 +363,8 @@ protected void initChannel(LocalChannel ch) throws
Exception {
}
}
- void start() {
+ void start() throws InterruptedException {
+ listenOn(bindAddress, bookieAddress);
Review comment:
any reason why listenOn is in #start() now?
I think this change would introduce a problem - because the listenOn method
is used for prevent two instances starting at the same time. If we change the
ordering here, it would cause a potential problem: there are two bookie
instances starting at the same time, they will try to replay the journal and
modifying ledger storage concurrently, it will cause issues.
At Twitter branch, we have a change to use file lock to prevent two
instances concurrently running. If that change is in, your change here is safe.
Otherwise, your change here will be a problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
