kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL
Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129642892
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -509,9 +509,12 @@ public static BookieSocketAddress
getBookieAddress(ServerConfiguration conf)
iface = "default";
}
InetSocketAddress inetAddr = new
InetSocketAddress(DNS.getDefaultHost(iface), conf.getBookiePort());
- String hostAddress = inetAddr.getAddress().getHostAddress();
- if (conf.getUseHostNameAsBookieID()) {
- hostAddress = inetAddr.getAddress().getCanonicalHostName();
+ String hostAddress = "127.0.0.1";
Review comment:
Makes sense, '127.0.0.1' will result in a wrong address to use if unresolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
