kishorekasi commented on a change in pull request #183: BOOKKEEPER-588 SSL
Support for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129646223
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieNettyServer.java
##########
@@ -272,7 +363,8 @@ protected void initChannel(LocalChannel ch) throws
Exception {
}
}
- void start() {
+ void start() throws InterruptedException {
+ listenOn(bindAddress, bookieAddress);
Review comment:
Didn't quite get it. The intention to move listenOn to start() was so that
if there is an error between initialization and start() we need not bind the
port and later cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
