sijie commented on a change in pull request #342: Issue 338: add first draft 
Docker image including community suggestions
URL: https://github.com/apache/bookkeeper/pull/342#discussion_r130796867
 
 

 ##########
 File path: docker/Dockerfile
 ##########
 @@ -0,0 +1,34 @@
+FROM centos:7
+MAINTAINER Apache BookKeeper <dev@bookkeeper.apache.org>
+
+ARG BK_VERSION=4.4.0
+ARG DISTRO_NAME=bookkeeper-server-${BK_VERSION}-bin
+ARG ZK_VERSION=3.5.2-alpha
+
+# Download Apache Bookkeeper and zookeeper, untar and clean up
+RUN set -x \
 
 Review comment:
   I think in #197, @caiok 's script verifies the download package. we should 
verify that md5, sha1 and asc for the downloaded package.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to