sijie commented on a change in pull request #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#discussion_r130937298
########## File path: docker/Dockerfile ########## @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +FROM centos:7 +MAINTAINER Apache BookKeeper <dev@bookkeeper.apache.org> + +ARG BK_VERSION=4.4.0 +ARG DISTRO_NAME=bookkeeper-server-${BK_VERSION}-bin +ARG ZK_VERSION=3.5.2-alpha + +ENV BOOKIE_PORT=3181 +EXPOSE $BOOKIE_PORT +ENV BK_USER=bookkeeper + +# Download Apache Bookkeeper and zookeeper, untar and clean up +RUN set -x \ + && adduser "${BK_USER}" \ + && yum install -y java-1.8.0-openjdk-headless wget bash python md5sum \ + && mkdir -pv /opt \ + && cd /opt \ + && wget -q "https://archive.apache.org/dist/bookkeeper/bookkeeper-${BK_VERSION}/${DISTRO_NAME}.tar.gz"; \ Review comment: we also need to verify sha1 and also gpg signature. I think @caiok 's change in #197 verifies gpg, your change here verify sha1. Can you combine these two and add a verification of sha1? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
