sijie commented on a change in pull request #342: Issue 338: add first draft Docker image including community suggestions URL: https://github.com/apache/bookkeeper/pull/342#discussion_r131525994
########## File path: docker/Dockerfile ########## @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +FROM centos:7 +MAINTAINER Apache BookKeeper <dev@bookkeeper.apache.org> + +ARG BK_VERSION=4.4.0 +ARG DISTRO_NAME=bookkeeper-server-${BK_VERSION}-bin +ARG GPG_KEY=B3D56514 + +ENV BOOKIE_PORT=3181 +EXPOSE $BOOKIE_PORT +ENV BK_USER=bookkeeper + +# Download Apache Bookkeeper, untar and clean up +RUN set -x \ + && adduser "${BK_USER}" \ + && yum install -y java-1.8.0-openjdk-headless wget bash python md5sum sha1sum \ + && mkdir -pv /opt \ + && cd /opt \ + && wget -q "https://archive.apache.org/dist/bookkeeper/bookkeeper-${BK_VERSION}/${DISTRO_NAME}.tar.gz"; \ + && wget -q "https://archive.apache.org/dist/bookkeeper/bookkeeper-${BK_VERSION}/${DISTRO_NAME}.tar.gz.asc"; \ + && wget -q "https://archive.apache.org/dist/bookkeeper/bookkeeper-${BK_VERSION}/${DISTRO_NAME}.tar.gz.md5"; \ + && wget -q "https://archive.apache.org/dist/bookkeeper/bookkeeper-${BK_VERSION}/${DISTRO_NAME}.tar.gz.sha1"; \ + && md5sum -c ${DISTRO_NAME}.tar.gz.md5 \ + && sha1sum -c ${DISTRO_NAME}.tar.gz.sha1 \ + && gpg --keyserver ha.pool.sks-keyservers.net --recv-key "$GPG_KEY" \ + && gpg --batch --verify "$DISTRO_NAME.tar.gz.asc" "$DISTRO_NAME.tar.gz" \ + && tar -xzf "$DISTRO_NAME.tar.gz" \ + && mv bookkeeper-server-${BK_VERSION}/ /opt/bookkeeper/ \ + && rm -rf "$DISTRO_NAME.tar.gz" "$DISTRO_NAME.tar.gz.asc" "$DISTRO_NAME.tar.gz.md5" "$DISTRO_NAME.tar.gz.sha1" \ + && yum remove -y wget \ + && yum clean all + +WORKDIR /opt/bookkeeper + +COPY scripts/apply-config-from-env.py scripts/entrypoint.sh scripts/healthcheck.sh /opt/bookkeeper/ + +ENTRYPOINT [ "/bin/bash", "/opt/bookkeeper/entrypoint.sh" ] +CMD ["/opt/bookkeeper/bin/bookkeeper", "bookie"] Review comment: I am wondering if you should auto-start the bookie in the docker image. it might be more flexible if we don't auto-start the bookie, and defer that deployment methods like dcos and k8s. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
