sijie commented on a change in pull request #425: BOOKKEEPER-1105:
RackAwarePolicy: Failure to map node into rack may result in failure to add
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133079593
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
##########
@@ -136,9 +208,11 @@ protected RackawareEnsemblePlacementPolicyImpl
initialize(DNSToSwitchMapping dns
int
maxWeightMultiple,
StatsLogger
statsLogger) {
this.statsLogger = statsLogger;
+ this.bookiesJoinedCounter = statsLogger == null ? null :
statsLogger.getOpStatsLogger(BookKeeperServerStats.BOOKIES_JOINED);
Review comment:
when the statsLogger would be null? we should use NullStatsLogger for the
`null` case, rather than passing in a `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
