sijie commented on a change in pull request #425: BOOKKEEPER-1105: 
RackAwarePolicy: Failure to map node into rack may result in failure to add 
other nodes.
URL: https://github.com/apache/bookkeeper/pull/425#discussion_r133078379
 
 

 ##########
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java
 ##########
 @@ -456,6 +572,7 @@ public BookieNode selectFromNetworkLocation(
             LOG.warn("Failed to choose a bookie from {} : "
                      + "excluded {}, fallback to choose bookie randomly from 
the cluster.",
                      networkLoc, excludeBookies);
+            LOG.warn("Predicate {}  Ensemble {}", predicate, ensemble);
 
 Review comment:
   This line doesn't give any useful information for debugging, isn't it?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to