Hey Enrico, Thanks for putting this together. I'm afraid it's a -1 from me on this bundle.
Artifacts should have rc in the version. Otherwise they'll eclipse the final release in people's maven caches. JLine is in the notice, but no file shipped. I ran the tests twice, and both times the following failed for me. They're probably flakes, but they failed on 2/2 so they should be investigated. This is on a machine that sometimes runs master tests cleanly (we really need to sort out our flakes). - BookKeeperAdminTest.testDecommissionBookie - TestRackawareEnsemblePlacementPolicyUsingScript.testNewEnsembleWithEnoughRacks - BookKeeperDiskSpaceWeightedLedgerPlacementTest -Ivan On Mon, Nov 6, 2017 at 11:31 AM, Enrico Olivelli <eolive...@gmail.com> wrote: > Hi everyone, > Please review and vote on the release candidate #0 for the version > 4.5.1, as follows: > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > * Release notes [1] > * The official Apache source and binary distributions to be deployed > to dist.apache.org [2] > * All artifacts to be deployed to the Maven Central Repository [3] > * Source code tag "release-4.5.1" [4] > > BookKeeper's KEYS file contains PGP keys we used to sign this > release:https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > Please download these packages and review this release candidate: > > - Review release notes > - Download the source package (verify md5, shasum, and asc) and follow the > instructions to build and run the bookkeeper service. > - Download the binary package (verify md5, shasum, and asc) and follow the > instructions to run the bookkeeper service. > - Review maven repo, release tag, licenses, and any other things you think > it is important to a release. > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PMC affirmative votes. > > Thanks, > Enrico Olivelli > > [1] https://github.com/apache/bookkeeper/pull/678 > [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.5.1-rc0/ > [3] > https://repository.apache.org/content/repositories/orgapachebookkeeper-1015/org/apache/bookkeeper/ > [4] https://github.com/apache/bookkeeper/tree/release-4.5.1
