+1(binding). - SHA512 & GPG signatures good - Rat and spotbugs good - local build, mvn test and integration test runs well - bookkeeper standalone and bookiesanity runs well for all and server bin.
On Tue, Sep 25, 2018 at 3:56 AM Ivan Kelly <iv...@apache.org> wrote: > Thanks for putting this together Enrico. I had left the test running > on friday and forgot to get back to it. > > +1 from me (binding). > > - Licenses good > - SHA512 & GPG signatures good > - Rat and spotbugs good > - mvn test runs cleanly without -Dstream & -DstreamTests > - integration tests run cleanly with -Dstream (the cli seems to depend > on something behind stream now) > > The only negative is that with (-Dstream & -DstreamTests), there's a > test that hangs consistently > > org.apache.bookkeeper.statelib.impl.kv.TestRocksdbKVAsyncStoreWithCheckpoints > > I haven't looked into what this is, but i don't think this failure is > enough to block the release. > > Cheers, > Ivan > > On Thu, Sep 20, 2018 at 12:59 PM, Enrico Olivelli <eolive...@gmail.com> > wrote: > > Hi everyone, > > Please review and vote on the release candidate #1 for the version 4.8.0, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > The complete staging area is available for your review, which includes: > > * Release notes [1] > > * The official Apache source and binary distributions to be deployed to > > dist.apache.org [2] > > * All artifacts to be deployed to the Maven Central Repository [3] > > * Source code tag "release-4.8.0rc1" [4] with git sha > > 6172e31465865bd57290905a98b5a57e4c3956a4 > > > > BookKeeper's KEYS file contains PGP keys we used to sign this release: > > https://dist.apache.org/repos/dist/release/bookkeeper/KEYS > > > > Please download these packages and review this release candidate: > > > > - Review release notes > > - Download the source package (verify shasum, and asc) and follow the > > instructions to build and run the bookkeeper service. > > - Download the binary package (verify shasum, and asc) and follow the > > instructions to run the bookkeeper service. > > - Review maven repo, release tag, licenses, and any other things you > think > > it is important to a release. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Enrico Olivelli > > > > [1] https://github.com/apache/bookkeeper/pull/1676 > > [2] > https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.8.0-rc1/ > > [3] > > > https://repository.apache.org/content/repositories/orgapachebookkeeper-1033/ > > [4] https://github.com/apache/bookkeeper/tree/v4.8.0-rc1 >
