Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1109#discussion_r47894122
--- Diff:
software/webapp/src/test/java/org/apache/brooklyn/entity/webapp/AbstractWebAppFixtureIntegrationTest.java
---
@@ -363,42 +353,90 @@ public void
publishesZeroRequestsPerSecondMetricRepeatedly(final SoftwareProcess
this.entity = entity;
log.info("test=publishesZeroRequestsPerSecondMetricRepeatedly;
entity="+entity+"; app="+entity.getApplication());
- final int MAX_INTERVAL_BETWEEN_EVENTS = 4000; // TomcatServerImpl
publishes events every 3000ms so this should be enough overhead
- final int NUM_CONSECUTIVE_EVENTS = 3;
+ final int maxIntervalBetweenEvents = 4000; // TomcatServerImpl
publishes events every 3000ms so this should be enough overhead
--- End diff --
Bike-shedding: I quite like the upper case, treating it like a constant
that is scoped to just the method. But no strong feelings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
