Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1109#issuecomment-165426211
@sjcorbett agreed this is a good improvement / short-term fix.
I think that long-term the right philosophy is that the service-down should
trigger the removal of this node from the calculations. Until that point, we
don't have enough info to know if it's still working away at its previous load
(in which case we don't want to zero the requests-per-second by publishing the
same total-request-count again), or if it is not doing anything.
If it were genuinely not doing anything, then we should mark it as
service-down.
This is obviously a fiddly thing to get right, particularly as there are
several failure scenarios and there are different ways the metrics are being
used.
@sjcorbett do you want to open a jira issue for us improving this long term?
Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
