Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-client/pull/18#discussion_r61277670
--- Diff: command_runner/runner.go ---
@@ -29,14 +30,22 @@ type Runner interface {
RunSubCmdByName(cmdName string, subCommand string, c *cli.Context) (err
error)
}
+type Factory interface {
--- End diff --
Why copy the interface here? The code actually now has three copies of
this, in `factory.go`, `runner.go` and `rpc_server.go`. Surely it's fine for
`factory.go` to declare it and have other code use it? Same thing applies to
`Runner` interface.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
