Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-client/pull/18#discussion_r61277898
--- Diff: command_runner/runner.go ---
@@ -29,14 +30,22 @@ type Runner interface {
RunSubCmdByName(cmdName string, subCommand string, c *cli.Context) (err
error)
}
+type Factory interface {
+ GetByCmdName(cmdName string) (cmd command.Command, err error)
+ GetBySubCmdName(cmdName string, subCmdName string) (cmd
command.Command, err error)
+ CommandMetadatas() []command_metadata.CommandMetadata
+}
+
type ConcreteRunner struct {
--- End diff --
Just noting in passing, there's no need to export this struct, we could
write it as `concreteRunner`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
