[
https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276397#comment-15276397
]
ASF GitHub Bot commented on BROOKLYN-259:
-----------------------------------------
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/132#discussion_r62503400
--- Diff:
core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java
---
@@ -147,8 +168,21 @@ public void init() {
}
config().set(MACHINE_SPECS, (List<LocationSpec<? extends
MachineLocation>>) null);
+ Supplier<? extends List<? extends MachineLocation>>
initialMachinesFactory = getConfig(INITIAL_MACHINES_FACTORY);
+ if (initialMachinesFactory != null) {
+ List<? extends MachineLocation> initialMachines =
initialMachinesFactory.get();
+ if (initialMachines != null) {
+ for (MachineLocation machine : initialMachines) {
+ @SuppressWarnings("unchecked")
+ T castMachine = (T) machine;
+ machines.add(castMachine);
--- End diff --
Probably worth checking that `machine` is not null too.
> jcloudsByon location spec leaks location instances
> --------------------------------------------------
>
> Key: BROOKLYN-259
> URL: https://issues.apache.org/jira/browse/BROOKLYN-259
> Project: Brooklyn
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Aled Sage
> Fix For: 0.10.0
>
>
> When declaring in brooklyn.properties a location spec such as
> {noformat}
> jcloudsByon(provider="aws-ec2",region="us-east-1",user="brooklyn",password="pa55w0rd",hosts="i-12345678")
> {noformat}
> It caused new locations to be created and persisted every few seconds, but
> for those locations to be never deleted.
> ---
> This was caused by changes made in 0.9.0 to {{LocationResolver}}
> implementations, so that it creates a {{LocationSpec}} rather than
> instantiating a location directly. Unfortunately,
> {{JcloudsByonLocationResolver}} had not been updated. The REST api would poll
> this regularly to find out about the types of location, and on every poll it
> would create new locations.
> This is similar to the problem encountered for localhost, fixed in time for
> 0.9.0 in https://github.com/apache/brooklyn-server/pull/97.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
