[
https://issues.apache.org/jira/browse/BROOKLYN-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277822#comment-15277822
]
ASF GitHub Bot commented on BROOKLYN-259:
-----------------------------------------
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/132#issuecomment-218096768
Spoke too soon on the location working with privateKey, throws an NPE when
deploying a docker infrastructure via Clocker:
```
Caused by: java.lang.NullPointerException: id
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:229)
~[guava-16.0.1.jar:na]
at
org.jclouds.compute.internal.BaseComputeService.getImage(BaseComputeService.java:410)
~[jclouds-compute-1.9.2.jar:1.9.2]
at
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation.getOptionalImage(JcloudsSshMachineLocation.java:226)
~[brooklyn-locations-jclouds-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation.getOptionalOperatingSystem(JcloudsSshMachineLocation.java:504)
~[brooklyn-locations-jclouds-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at
org.apache.brooklyn.location.jclouds.JcloudsSshMachineLocation.inferMachineDetails(JcloudsSshMachineLocation.java:522)
~[brooklyn-locations-jclouds-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at
org.apache.brooklyn.location.ssh.SshMachineLocation.getMachineDetails(SshMachineLocation.java:1056)
~[brooklyn-core-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at
clocker.docker.entity.DockerHostSshDriver.install(DockerHostSshDriver.java:183)
~[brooklyn-clocker-docker-1.2.0-SNAPSHOT.jar:1.2.0-SNAPSHOT]
at
org.apache.brooklyn.entity.software.base.AbstractSoftwareProcessDriver$2$6.run(AbstractSoftwareProcessDriver.java:159)
~[brooklyn-software-base-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
~[na:1.7.0_99]
at
org.apache.brooklyn.util.core.task.DynamicSequentialTask$DstJob.call(DynamicSequentialTask.java:359)
~[brooklyn-core-0.10.0-SNAPSHOT.jar:0.10.0-SNAPSHOT]
... 5 common frames omitted
```
> jcloudsByon location spec leaks location instances
> --------------------------------------------------
>
> Key: BROOKLYN-259
> URL: https://issues.apache.org/jira/browse/BROOKLYN-259
> Project: Brooklyn
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Aled Sage
> Fix For: 0.10.0
>
>
> When declaring in brooklyn.properties a location spec such as
> {noformat}
> jcloudsByon(provider="aws-ec2",region="us-east-1",user="brooklyn",password="pa55w0rd",hosts="i-12345678")
> {noformat}
> It caused new locations to be created and persisted every few seconds, but
> for those locations to be never deleted.
> ---
> This was caused by changes made in 0.9.0 to {{LocationResolver}}
> implementations, so that it creates a {{LocationSpec}} rather than
> instantiating a location directly. Unfortunately,
> {{JcloudsByonLocationResolver}} had not been updated. The REST api would poll
> this regularly to find out about the types of location, and on every poll it
> would create new locations.
> This is similar to the problem encountered for localhost, fixed in time for
> 0.9.0 in https://github.com/apache/brooklyn-server/pull/97.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
