Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71247868
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -379,20 +418,30 @@ public MachineLocation call() throws Exception {
if (!(location instanceof
LocalhostMachineProvisioningLocation))
log.info("Starting {}, obtaining a new location instance
in {} with ports {}", new Object[]{entity(), location,
flags.get("inboundPorts")});
entity().sensors().set(SoftwareProcess.PROVISIONING_LOCATION,
location);
+ Transition expectedState =
entity().sensors().get(Attributes.SERVICE_STATE_EXPECTED);
+
+ // BROOKLYN-263: see corresponding code in doStop()
+ if (expectedState != null && (expectedState.getState() ==
Lifecycle.STOPPING || expectedState.getState() == Lifecycle.STOPPED)) {
--- End diff --
Good check, but should it be in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
