Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71314400
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -444,9 +493,6 @@ public void run() {
}
}
entity().addLocations(ImmutableList.of((Location) machine));
- if
(entity().getAttribute(Attributes.JCLOUDS_PROVISIONING_RUNNING) != null) {
--- End diff --
I'll rename the sensors to include "internal" in their names, as well as in
the description.
The reason I didn't like this approach was that if `obtain()` failed, we
would wait for the max time before stop continued - there was no way for it to
terminate early. I'll add a test for that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
