Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/287#discussion_r73673275
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java ---
    @@ -421,6 +421,7 @@ public void setDisplayName(String name) {
         public void setEntity(EntityLocal entity) {
             if (destroyed.get()) throw new IllegalStateException("Cannot set 
entity on a destroyed entity adjunct");
             this.entity = entity;
    +        this.execution = ((EntityInternal) entity).getExecutionContext();
    --- End diff --
    
    I'm guessing you hit a problem that made you add this line - can we capture 
in a test what that problem was, rather than just fixing it?
    
    I'm fine with merging this time, but for future reference I am really keen 
that we improve our test coverage for when we hit problems like this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to