Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73673387
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalPolicyFactory.java
---
@@ -125,7 +124,6 @@ public InternalPolicyFactory(ManagementContextInternal
managementContext) {
for (Map.Entry<ConfigKey<?>, Object> entry :
spec.getConfig().entrySet()) {
pol.config().set((ConfigKey)entry.getKey(),
entry.getValue());
}
- ConfigConstraints.assertValid(pol);
--- End diff --
Ah, I see you've removed the `assertValid` here. Why? Is that because the
policy/enricher won't have finished initialising until `setEntity` etc is
called? Is that an indication of a poorly implemented policy? Or the right
thing to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
