Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r76590901
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/http/HttpTool.java ---
@@ -250,6 +254,21 @@ public static HttpClientBuilder httpClientBuilder() {
private boolean trustAll;
private boolean trustSelfSigned;
+ public static HttpClientBuilder fromBuilder(HttpClientBuilder
other) {
+ HttpClientBuilder result = httpClientBuilder();
+ result.clientConnectionManager = other.clientConnectionManager;
+ result.httpParams = other.httpParams;
--- End diff --
HttpClient should be configured with `clientConnectionManager` possibly the
`HttpExecutorFactory` and other similar client properties.
A client can be used against multiple endpoints so including `uri`, `port`
and `credentials` is not appropriate for the HttpClientBulder in my opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
