Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r77347841
--- Diff: core/src/main/java/org/apache/brooklyn/feed/http/HttpFeed.java ---
@@ -275,7 +294,23 @@ public HttpFeed() {
protected HttpFeed(Builder builder) {
setConfig(ONLY_IF_SERVICE_UP, builder.onlyIfServiceUp);
Map<String,String> baseHeaders =
ImmutableMap.copyOf(checkNotNull(builder.headers, "headers"));
-
+
+ HttpExecutor httpExecutor;
+ if (builder.httpExecutor != null) {
+ httpExecutor = builder.httpExecutor;
+ } else {
+ HttpExecutorFactory httpExecutorFactory = null;
+ Collection<? extends Location> locations =
Locations.getLocationsCheckingAncestors(builder.entity.getLocations(),
builder.entity);
+ Maybe<Location> location =
Machines.findUniqueElement(locations, Location.class);
--- End diff --
All of the elements here are of type `Location`. It's possible to have two
locations per entity - one coming from `location: xx` property in YAML (which
is the description of how to provision a new machine) and another
`SshMachineLocation` (which points to a specific VM with IPs created from the
previous one). I believe only the former will have the extensions when coming
from yaml (they will not be inherited). Looking for the first location to have
the required extension should be good enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
