Github user aledsage commented on the issue:
    Thanks @ahgittin - finished reviewing.
    Overall I'm happy with this. I agree that it feels very complicated (and 
some of the code is quite subtle, so could do with a more thorough review!).
    Are there situations (such as the `NOT_REINHERITABLE` 
app->child->grandchild) that are not tested?
    I'm fine with this being merged when you're ready.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to