Github user aledsage commented on a diff in the pull request:
    --- Diff: 
    @@ -72,6 +72,7 @@ public void setUp() throws Exception {
             emptyFile = Files.createTempFile("ConfigInheritanceYamlTest", 
             emptyFile2 = Files.createTempFile("ConfigInheritanceYamlTest2", 
    +        emptyFile3 = Files.createTempFile("ConfigInheritanceYamlTest3", 
    --- End diff --
    I'd still prefer deleting immediately in tearDown, as `Os.newTempFile` only 
sets `deleteOnExit()` (so will not delete it if the process is killed).

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to