[
https://issues.apache.org/jira/browse/BROOKLYN-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15591365#comment-15591365
]
ASF GitHub Bot commented on BROOKLYN-356:
-----------------------------------------
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/390
BROOKLYN-356: fix race in transformer by adding getImmediately
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
BROOKLYN-356-getImmediately
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit 77b06dd664c03371746bf9c9c9cf808ead8e125d
Author: Aled Sage <[email protected]>
Date: 2016-10-13T21:46:57Z
Subscription callbacks: task has contextEntity tag
commit 9b896cbc5abdb03d886a4c98d8323d63fa7bc26f
Author: Aled Sage <[email protected]>
Date: 2016-10-18T18:08:18Z
BROOKLYN-356: threading for DSL task
Adds ImmediateSupplier, so can fetch Maybe<?> of DSL value immediately,
in current thread (rather than invoking in task with a timeout).
commit 516128f56197763d5f15850336d2af85ce8197b4
Author: Aled Sage <[email protected]>
Date: 2016-10-19T14:46:53Z
Reflections utils: improve use of generics
----
> The sensor Transformer enricher fails to resolve its targetValue
> indeterministically.
> -------------------------------------------------------------------------------------
>
> Key: BROOKLYN-356
> URL: https://issues.apache.org/jira/browse/BROOKLYN-356
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Svetoslav Neykov
>
> The sensor {{Transformer}} enricher fails to resolve its {{targetValue}}
> indeterministically, especially so on loaded systems. This is especially
> problematic if sourceSensor/triggerSensors change infrequently or do not
> change ever (when using default values).
> Bueprints using the {{Transformer}} behave perfectly fine during development
> and on test setups, but will fail on production machines (i.e. under load).
> The code [doing the value
> resolving|https://github.com/apache/brooklyn-server/blob/b59e7463a9b337c2d0e7931cd420d5bac68d8549/core/src/main/java/org/apache/brooklyn/enricher/stock/Transformer.java#L90-L94]
> tries to do so in a non-blocking fashion by spinning a thread to try to
> resolve and cancelling it after a short while without guarantees it ever got
> scheduled to run. It's more likely to fail when nesting DSLs, for example
> nesting several levels of {{$brooklyn:formatString}} and ending with a
> {{$brooklyn:attributeWhenRready}}. It's a common pattern in moderately
> complex blueprints. It needs to schedule a thread for each nesting level thus
> maximizing the chance that the value will not be resolved in the allotted
> time even if resolvabe. This is especially bad for sensors which don't get
> updated, for example {{PortAttributeSensorAndConfigKey} set only when
> initializing the entity or any config values which are always resolvable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
