[
https://issues.apache.org/jira/browse/BROOKLYN-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609466#comment-15609466
]
ASF GitHub Bot commented on BROOKLYN-356:
-----------------------------------------
Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/390#discussion_r85202543
--- Diff:
core/src/test/java/org/apache/brooklyn/core/entity/EntitySubscriptionTest.java
---
@@ -280,4 +279,55 @@ public void
testSubscriptionForInitialValueWhenNotValid() {
entity.subscriptions().subscribe(ImmutableMap.of("notifyOfInitialValue", true),
null, TestEntity.NAME, listener);
entity.subscriptions().subscribe(ImmutableMap.of("notifyOfInitialValue", true),
null, null, listener);
}
+
+ @Test
+ public void testContextEntityOnSubscriptionCallbackTask() {
+ observedEntity.sensors().set(TestEntity.NAME, "myval");
+
entity.subscriptions().subscribe(ImmutableMap.of("notifyOfInitialValue", true),
observedEntity, TestEntity.NAME, listener);
+
+ // notify-of-initial-value should give us our entity
+ assertListenerCalledOnceWithContextEntityEventually(listener,
entity);
+ listener.clearEvents();
+
+ // as should subsequent events
+ observedEntity.sensors().set(TestEntity.NAME, "myval2");
+ assertListenerCalledOnceWithContextEntityEventually(listener,
entity);
+ listener.clearEvents();
+
+ // same for subscribing to children: context should be the
subscriber
+ entity.subscriptions().subscribeToChildren(observedEntity,
TestEntity.SEQUENCE, listener);
+ observedChildEntity.sensors().set(TestEntity.SEQUENCE, 123);
+ assertListenerCalledOnceWithContextEntityEventually(listener,
entity);
+ listener.clearEvents();
--- End diff --
should this be in a `tearDown`?
> The sensor Transformer enricher fails to resolve its targetValue
> indeterministically.
> -------------------------------------------------------------------------------------
>
> Key: BROOKLYN-356
> URL: https://issues.apache.org/jira/browse/BROOKLYN-356
> Project: Brooklyn
> Issue Type: Bug
> Reporter: Svetoslav Neykov
>
> The sensor {{Transformer}} enricher fails to resolve its {{targetValue}}
> indeterministically, especially so on loaded systems. This is especially
> problematic if sourceSensor/triggerSensors change infrequently or do not
> change ever (when using default values).
> Bueprints using the {{Transformer}} behave perfectly fine during development
> and on test setups, but will fail on production machines (i.e. under load).
> The code [doing the value
> resolving|https://github.com/apache/brooklyn-server/blob/b59e7463a9b337c2d0e7931cd420d5bac68d8549/core/src/main/java/org/apache/brooklyn/enricher/stock/Transformer.java#L90-L94]
> tries to do so in a non-blocking fashion by spinning a thread to try to
> resolve and cancelling it after a short while without guarantees it ever got
> scheduled to run. It's more likely to fail when nesting DSLs, for example
> nesting several levels of {{$brooklyn:formatString}} and ending with a
> {{$brooklyn:attributeWhenRready}}. It's a common pattern in moderately
> complex blueprints. It needs to schedule a thread for each nesting level thus
> maximizing the chance that the value will not be resolved in the allotted
> time even if resolvabe. This is especially bad for sensors which don't get
> updated, for example {{PortAttributeSensorAndConfigKey} set only when
> initializing the entity or any config values which are always resolvable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
