Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/409#discussion_r86738261
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/sshj/SshjTool.java
---
@@ -273,13 +273,8 @@ private int copyToServer(Map<String,?> props,
Supplier<InputStream> contentsSupp
@Override
public int copyFromServer(Map<String,?> props, String
pathAndFileOnRemoteServer, File localFile) {
- InputStream contents = acquire(new
GetFileAction(pathAndFileOnRemoteServer));
- try {
- FileUtil.copyTo(contents, localFile);
- return 0; // TODO Can we assume put will have thrown exception
if failed? Rather than exit code != 0?
- } finally {
- Streams.closeQuietly(contents);
- }
+ LocalDestFile localDestFile = acquire(new
GetFileAction(pathAndFileOnRemoteServer));
--- End diff --
ops, you are right!
seems like the only test capturing that is in
`SshToolAbstractIntegrationTest` which is marked as `integration` -- I'll try
to fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
