Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-server/pull/409
  
    I also have integration test failures on this branch:
    ```
      SshjToolIntegrationTest.testAsyncExecAbortsIfProcessFails:273 expected 
[false] but found [true]
      SshjToolIntegrationTest.testAsyncExecTimesOut:234 exec took 301 seconds 
expected [true] but found [false]
    ```
    In both cases the behaviour actually being tested works as expected but it 
fails to clean up temporary files afterwards, blocking on this line of 
`SshjTool`:
    ```
    int execDeleteResult = asInt(acquire(new 
ShellAction(deleteTemporaryFilesCommand(), out, err, pollTimeout)), -1)
    ```
    The tests block waiting for the channel to close:
    ```
    "main" #1 prio=5 os_prio=31 tid=0x00007fd9fc800000 nid=0x1703 waiting on 
condition [0x0000700000217000]
       java.lang.Thread.State: TIMED_WAITING (parking)
            at sun.misc.Unsafe.park(Native Method)
            - parking to wait for  <0x00000007b9ff5468> (a 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
            at 
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
            at 
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2163)
            at net.schmizz.concurrent.Promise.tryRetrieve(Promise.java:170)
            at net.schmizz.concurrent.Promise.retrieve(Promise.java:137)
            at net.schmizz.concurrent.Event.await(Event.java:103)
            at 
net.schmizz.sshj.connection.channel.AbstractChannel.join(AbstractChannel.java:259)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool$ShellAction.create(SshjTool.java:1007)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool$ShellAction.create(SshjTool.java:924)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool.acquire(SshjTool.java:625)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool.acquire(SshjTool.java:611)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool$2.run(SshjTool.java:433)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool.execScriptAsyncAndPoll(SshjTool.java:544)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjTool.execScript(SshjTool.java:316)
            at 
org.apache.brooklyn.util.core.internal.ssh.sshj.SshjToolIntegrationTest.testAsyncExecTimesOut(SshjToolIntegrationTest.java:221)
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    ```
    If you enable sshj's debug log you'll see lots of messages like:
    ```
    DEBUG net.schmizz.concurrent.Promise [main]: Awaiting <<chan#4 / close>>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to