Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/414#discussion_r86971541
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCall.java
---
@@ -32,9 +36,34 @@
@SetFromFlag(nullable = false)
ConfigKey<String> TARGET_URL = ConfigKeys.newStringConfigKey("url",
"URL to test");
+ @SetFromFlag(nullable = false)
+ ConfigKey<HttpMethod> TARGET_METHOD =
ConfigKeys.builder(HttpMethod.class)
+ .name("method")
+ .description("Method to request the URL: GET, POST, PUT,
DELETE, etc")
+ .defaultValue(HttpMethod.GET)
+ .build();
+
+ @SetFromFlag
+ ConfigKey<Map<String, String>> TARGET_HEADERS = ConfigKeys.builder(new
TypeToken<Map<String, String>>() {})
--- End diff --
I wonder if we should use type `org.apache.commons.collections.MultiMap`,
and add to `CommonAdaptorTypeCoercions.registerStandardAdapters` a coercion
from `java.util.Map` to `MultiMap`.
But probably not worth it, given that yaml won't support a map with
duplicate keys anyway!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
