Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/414#discussion_r86971996
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCallImpl.java
---
@@ -77,13 +88,18 @@ public void start(Collection<? extends Location>
locations) {
}
private void doRequestAndCheckAssertions(Map<String, Duration> flags,
List<Map<String, Object>> assertions,
- HttpAssertionTarget target,
final String url) {
+ HttpAssertionTarget target,
final HttpMethod method, final String url, final Map<String, String> headers,
final String body) {
switch (target) {
case body:
Supplier<String> getBody = new Supplier<String>() {
@Override
public String get() {
- return HttpTool.getContent(url);
+ try {
+ return
HttpTool.execAndConsume(HttpTool.httpClientBuilder().build(),
createHttpMethod(method, url, headers, body)).getContentAsString();
--- End diff --
Minor: a couple of very long lines here. Probably worth splitting them up
for readability (particularly as there is another method call at the end of
this one, which can easily be missed if someone doesn't scroll).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
