GitHub user grkvlt opened a pull request:

    https://github.com/apache/brooklyn-server/pull/445

    Use subnet IP on machine locations that dont implement HasSubnetHostname

    The `SshMachineLocation` interface does *NOT* implement `HasSubnetHostname` 
but it does include the method `getPrivateAddresses()` which means that when 
something creates a machine and sets the config key 
`SshMachineLocation.PRIVATE_ADDRESSES` with the private IP then the 
`machines.getSubnetHostname(Location)` helper method (called during entity 
startup) will happily set the `SUBNET_HOSTNAME` attribute to the public IP (via 
`location.getAddress().getHostAddress()`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/brooklyn-server 
subnet-hostname-private-addresses

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #445
    
----
commit eb03f6276ffe36abc91fac07d317e9896ce9abd5
Author: Andrew Donald Kennedy <[email protected]>
Date:   2016-11-18T17:18:43Z

    Use subnet IP on machine locations that dont implement HasSubnetHostname

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to