Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/445
  
    This change makes sense to me.
    
    For those interested, here are a couple of contexts where it's useful:
    1. if there is a custom location type that create `SshMachineLocation` 
instances (i.e. not using `JcloudsLocation`, which creates 
`JcloudsSshMachineLocation`), then those instances might have different 
addresses for inside and outside the subnet.
    2. if using BYON, then one can have machines that have subnet and public 
address, so you'd want the subsequent `SshMachineLocation` to correctly 
advertise both.
    
    It's important to advertise the right subnet address. For example, the 
nginx entity by default monitors its members' `host.subnet.hostname` 
(controlled via the sensor `member.sensor.hostname`).
    
    ---
    @grkvlt can you add test(s) please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to