Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/454#discussion_r89315698
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java
---
@@ -742,7 +742,7 @@ private boolean unmanageNonRecursive(Entity e) {
if (e instanceof Group) {
Collection<Entity> members = ((Group)e).getMembers();
for (Entity member : members) {
- if (!Entities.isNoLongerManaged(member))
member.removeGroup((Group)e);
+ if (!Entities.isNoLongerManaged(member))
((EntityInternal)member).groups().remove((Group)e);
--- End diff --
You're right that this should be in its own PR - It's unrelated to the
private fields. I was just being lazy. I'll separate it out.
The change is just to get rid of deprecation warnings - to remove the calls
to `removeGroup` and `addGroup` with the equivalent recommended calls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
