Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/454#discussion_r89320291
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java
---
@@ -742,7 +742,7 @@ private boolean unmanageNonRecursive(Entity e) {
if (e instanceof Group) {
Collection<Entity> members = ((Group)e).getMembers();
for (Entity member : members) {
- if (!Entities.isNoLongerManaged(member))
member.removeGroup((Group)e);
+ if (!Entities.isNoLongerManaged(member))
((EntityInternal)member).groups().remove((Group)e);
--- End diff --
I guess what I am saying is that these are not the recommended calls, as
far as I understand. `.removeGroup()` is just doing the same thing under the
hood as `groups().remove()`. Should we not be using `Group#removeMember()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
