GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/484
Small JcloudsLocation refactor
I took the opportunity to move a number of the supporting classes in
`JcloudsLocation` to their own top-level classes. I particular I touched
`RebindToMachinePredicate`, the logic for creating users, and all of the
`CustomizeTemplateOptions` and `CustomizeTemplateBuilders`.
It's a fairly large PR but I haven't introduced much that's new or changed
any existing functionality. Most of it is ASF license headers.
Suggest reviewing it with whitespace changes disabled (append `?w=1` to
GitHub's URL).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server jclouds-location
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/484.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #484
----
commit c82d1679ecb545045914fc5312cf6aef32a44bb1
Author: Sam Corbett <[email protected]>
Date: 2016-12-01T15:11:24Z
Deletions, deprecations and typos
* Remove ComputeService arg from
JcloudsLocation.resolveManagementHostAndPort
* Improve javadoc for Duration.of
* Deprecate Attributes.HOST_AND_PORT and delete Attributes.SERVICE_STATE
* Miscellaneous typos
* Readability of JcloudsLocation and related classes
* Delete method commented out for two years
* Remove ComputeService arg from
JcloudsLocation.resolveManagementHostAndPort
commit cde849b4cbaecf2e8da5bd09809c279ad823b800
Author: Sam Corbett <[email protected]>
Date: 2016-12-07T11:56:40Z
Move JcloudsLocation's logic for creating users to separate class
commit 2d6071f12eaff646bfd535e3d22648a6bfc84724
Author: Sam Corbett <[email protected]>
Date: 2016-12-07T12:06:02Z
Extract RebindToMachinePredicate from JcloudsLocation
commit cfeb4109529f9578fa892d40acf7b7809df00335
Author: Sam Corbett <[email protected]>
Date: 2016-12-09T16:46:46Z
Extract CustomizeTemplateOptions and its implementations from
JcloudsLocation
commit 364218eb842c8af0b29324279d0cb8516c285a13
Author: Sam Corbett <[email protected]>
Date: 2016-12-09T17:29:55Z
Extract CustomizeTemplateBuilder from JcloudsLocation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
