Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/338#discussion_r94762563
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/AbstractMemento.java
---
@@ -85,7 +103,9 @@ public B customFields(Map<String,?> vals) {
private String type;
private String id;
private String displayName;
- private String catalogItemId;
+ // catalogItemId is retained to support rebind of previously persisted
state (prior to catalogItemSuperIds)
+ protected String catalogItemId;
+ private List<String> catalogItemSuperIds = MutableList.of();
--- End diff --
Constructors are not called during xstream deserialization so this is not
guaranteed to be non-null. Might be better to leave it null and explicitly deal
with it in the code (as you already do) - to prevent others making false
assumptions about the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
