Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/338#discussion_r94753587
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java
---
@@ -318,4 +327,26 @@ public static void setDisabled(ManagementContext mgmt,
String symbolicName, Stri
mgmt.getCatalog().persist(item);
}
+ public static BrooklynClassLoadingContextSequential
newClassLoadingContextForCatalogItems(
+ ManagementContext managementContext, List<String> catalogItemIds) {
+
+ BrooklynClassLoadingContextSequential seqLoader =
+ new BrooklynClassLoadingContextSequential(managementContext);
+ for (String catalogItemId : catalogItemIds) {
+ addCatalogItemContext(managementContext, seqLoader,
catalogItemId);
+ }
+ return seqLoader;
+ }
+
+ private static void addCatalogItemContext(ManagementContext
managementContext, BrooklynClassLoadingContextSequential loader, String
catalogItemId) {
+ RegisteredType item =
managementContext.getTypeRegistry().get(catalogItemId);
+
+ if (item != null) {
+ BrooklynClassLoadingContext itemLoader =
newClassLoadingContext(managementContext, item);
+ loader.add(itemLoader);
+ } else {
+ // TODO review what to do here
+ log.debug("Can't find catalog item " + catalogItemId);
--- End diff --
At the very least could log at higher level - code at
`AbstractManagementContext` used to log at `error`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
