Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94984944
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/JcloudsProviderAndApiLoaderTest.java
---
@@ -68,6 +69,35 @@ public void testRegisteredProvider() throws Exception {
ProviderRegistry.unregisterProvider(provider);
}
}
+
+ @Test
+ public void testRenamedRegisteredProvider() throws Exception {
+ String id = "my-example-provider";
+ String renamedId = "my-example-provider-renamed";
--- End diff --
Personal preference for using "oldId" and "newId". When I first read the
variable names, It thought that "renamedId" was going to be what the provider
had been renamed *to*, rather than what it was renamed *from*.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
