Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/508#discussion_r94983260
--- Diff:
core/src/main/java/org/apache/brooklyn/core/mgmt/persist/ClasspathConfigLoader.java
---
@@ -18,55 +18,17 @@
*/
package org.apache.brooklyn.core.mgmt.persist;
-import java.io.IOException;
-import java.io.InputStream;
-import java.util.Enumeration;
-import java.util.Map;
-import java.util.Properties;
-
-import org.apache.brooklyn.util.core.ResourceUtils;
-import org.apache.brooklyn.util.exceptions.Exceptions;
-import org.apache.brooklyn.util.stream.Streams;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.Maps;
-
/**
* Loads the class-renames from the configuration file on the classpath.
*
* @see {@link #DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH}
*/
-public class ClasspathConfigLoader implements ConfigLoader {
- private static final Logger LOG =
LoggerFactory.getLogger(ClasspathConfigLoader.class);
- private static final String
DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH =
"classpath://org/apache/brooklyn/core/mgmt/persist/deserializingClassRenames.properties";
+public class ClasspathConfigLoader extends PropertiesConfigLoader {
--- End diff --
I don't think this class pulls its weight anymore. I'd delete it, and just
have the thing that constructed it call `new
PropertiesConfigLoader(DESERIALIZING_CLASS_RENAMES_PROPERTIES_PATH)`.
I might then rename `PropertiesConfigLoader` to indicate that it's loading
the properties from the classpath.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
