Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/462#discussion_r94780176
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java
 ---
    @@ -403,8 +408,10 @@ protected ConfigInheritance 
getDefaultConfigInheritance() {
             // name "B" the "val2" then applies to both!
             //
             // I plan to propose a change on dev@brooklyn, to replace 
`@SetFromFlag`!
    -        
    -        Set<FlagConfigKeyAndValueRecord> allKeys = MutableSet.of();
    +
    +        // need to de-dupe? (can't use Set bc FCKVR doesn't impl 
equals/hashcode)
    --- End diff --
    
    It's `FCKAVR`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to