Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/462#discussion_r94782620
--- Diff:
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/SpecParameterUnwrappingTest.java
---
@@ -146,8 +151,9 @@ public void testRootParametersUnwrapped() {
CatalogItem<?, ?> item = catalog.getCatalogItem(SYMBOLIC_NAME,
TEST_VERSION);
AbstractBrooklynObjectSpec<?,?> spec = catalog.peekSpec(item);
List<SpecParameter<?>> params = spec.getParameters();
- assertEquals(params.size(), NUM_APP_DEFAULT_CONFIG_KEYS + 1,
"params="+params);
assertTrue(Iterables.tryFind(params,
nameEqualTo("simple")).isPresent());
+ assertTrue(Iterables.tryFind(params,
nameEqualTo(SHARED_CONFIG.getName())).isPresent());
+ assertEquals(params.size(), NUM_APP_DEFAULT_CONFIG_KEYS + 2,
"params="+params);
--- End diff --
Could introduce `NUM_CONFIG_ENTITY_FOR_TEST_CONFIG_KEYS` and change this to
`NUM_APP_DEFAULT_CONFIG_KEYS + NUM_CONFIG_ENTITY_FOR_TEST_CONFIG_KEYS + 1`,
not clear why the `+2` otherwise (same for following changes).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
