Github user geomacy commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/513#discussion_r95572556
--- Diff:
utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java
---
@@ -75,6 +76,20 @@
}
}
+ /**
+ * Alternative implementation of {@link
ScriptBytecodeAdapter#isCase(Object, Object)}<br>
+ * Stripped down to work only for caseExpression of type
<code>java.lang.Class</code>.<br>
--- End diff --
My point is that _if_ we don't need the functionality that
`ScriptBytecodeAdapter` was giving us, then we should keep it as simple as
possible; otherwise people will be looking at this code thinking "why is the
call to this Groovy stuff needed?" when in fact it's not. It will be confusing.
There's no need for it to do "isCase" any more, is there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
